API: move ostypeid from DB id to DB uuid, backports #2528#3066
API: move ostypeid from DB id to DB uuid, backports #2528#3066yadvr merged 1 commit intoapache:4.11from
Conversation
yadvr
left a comment
yadvr
left a comment
There was a problem hiding this comment.
LGTM, same as the already merged PR on master.
|
This is same as: #2608 |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2472 |
|
@blueorangutan test |
|
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
yadvr
requested review from
GabrielBrascher,
rafaelweingartner,
resmo and
wido
borisstoyanov
left a comment
borisstoyanov
left a comment
There was a problem hiding this comment.
With these changes response looks like this:
(localcloud) SBCM5> > list virtualmachines id=6110274a-b86e-4964-b964-f54fec0360e2 filter=name,ostypeid
{
"count": 1,
"virtualmachine": [
{
"name": "VM-6110274a-b86e-4964-b964-f54fec0360e2",
"ostypeid": "d4db1769-f3be-11e8-86d3-063e32010711"
}
]
}
wido
left a comment
wido
left a comment
There was a problem hiding this comment.
LGTM based on the code
We should never return the database IDs, but return a UUID in all cases.
|
Trillian test result (tid-3236)
|
5 participants
Description
This is a backport to 4.11 of #2528
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Locally